timeline: Fix HTML source processing, load WebChannel from Qt resource system #3702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error spit out when Travis ran the unit tests:
Also fixes a few
setInterval()
calls we were making using float arguments, leading to:qwebchannel.js
: That file is automatically present in Qt builds that support it via the Qt resource system.QtWebEnginePage
supports accessing Qt resources from HTML asqrc:
URLs. So instead of keepingqwebchannel.js
on the filesystem and conditionally inserting code to load it, we can just place a<script>
tag in the HTML that loads the source asqrc:/qtwebchannel/qwebchannel.js
. If the code isn't running in a QtWebEngine process, that URL will be invalid and the script tag will be silently ignored.